Skip to content

feat(list-overrides): show per-package min_release_age in --details output#1100

Open
shifa-khan wants to merge 1 commit intopython-wheel-build:mainfrom
shifa-khan:list-overrides-1079
Open

feat(list-overrides): show per-package min_release_age in --details output#1100
shifa-khan wants to merge 1 commit intopython-wheel-build:mainfrom
shifa-khan:list-overrides-1079

Conversation

@shifa-khan
Copy link
Copy Markdown
Contributor

@shifa-khan shifa-khan commented Apr 30, 2026 •
edited
Loading

Add a "Min Release Age (days)" column to list-overrides --details for all output formats (table, CSV, JSON). The column shows the per-package resolver_dist.min_release_age override value, or an empty string when the package inherits the global --min-release-age setting.

Closes: #1079

@shifa-khan shifa-khan requested a review from a team as a code owner April 30, 2026 22:17
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 47987398-2f87-40a4-8c32-ec4105b70cb2

📥 Commits

Reviewing files that changed from the base of the PR and between 8a4e5ad and 590fc2a.

📒 Files selected for processing (4)
  • src/fromager/commands/list_overrides.py
  • tests/test_list_overrides.py
  • tests/test_packagesettings.py
  • tests/testdata/context/overrides/settings/test_cooldown_pkg.yaml
✅ Files skipped from review due to trivial changes (2)
  • tests/testdata/context/overrides/settings/test_cooldown_pkg.yaml
  • tests/test_packagesettings.py
🚧 Files skipped from review as they are similar to previous changes (2)
  • tests/test_list_overrides.py
  • src/fromager/commands/list_overrides.py
📝 Walkthrough

Walkthrough

This PR implements support for displaying per-package min_release_age values in the list-overrides --details command output. The main change normalizes the min_release_age field from package settings and injects it into exported override rows. CSV and Rich table exporters are updated to include the new column, while JSON export behavior remains unchanged. Test coverage is extended across multiple output formats, and new test data with a sample override configuration is added.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a min_release_age column to list-overrides output with --details flag.
Description check ✅ Passed The description is directly related to the changeset, explaining what was added (Min Release Age column) and for which formats (table, CSV, JSON).
Linked Issues check ✅ Passed The PR fully addresses issue #1079 by implementing the new min_release_age column across all --details output formats (table, CSV, JSON) as required.
Out of Scope Changes check ✅ Passed All changes are within scope: implementation of min_release_age display in list-overrides, corresponding test updates, and test data configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the ci label Apr 30, 2026
@shifa-khan shifa-khan force-pushed the list-overrides-1079 branch from 8a4e5ad to 303722f Compare April 30, 2026 22:19
@shifa-khan shifa-khan changed the title show per-package min_release_age in --details output feat(list-overrides): show per-package min_release_age in --details output Apr 30, 2026
@shifa-khan shifa-khan force-pushed the list-overrides-1079 branch from 303722f to e9980bf Compare April 30, 2026 23:03
@shifa-khan @claude
feat(list-overrides): show per-package min_release_age in --details o…
590fc2a 
…utput

Add a "Min Release Age (days)" column to `list-overrides --details` for
all output formats (table, CSV, JSON). The column shows the per-package
`resolver_dist.min_release_age` override value, or an empty string when
the package inherits the global --min-release-age setting.

Co-Authored-By: Claude <claude@anthropic.com>
Closes: python-wheel-build#1079
@shifa-khan shifa-khan force-pushed the list-overrides-1079 branch from e9980bf to 590fc2a Compare May 1, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanpetrello ryanpetrello Awaiting requested review from ryanpetrello

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

list-overrides: show per-package min_release_age values

1 participant

@shifa-khan